Implement image description viewer #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sk22
commented
May 5, 2022
Comment on lines
+47
to
+51
| TextView heading=new TextView(activity); | ||
| heading.setText(R.string.image_description); | ||
| heading.setAllCaps(true); | ||
| heading.setTypeface(null, Typeface.BOLD); | ||
| heading.setPadding(0, V.dp(24), 0, V.dp(8)); |
There was a problem hiding this comment.
Not sure about this. Is there a specific styling more suitable for headings?
sk22
commented
May 5, 2022
| handleView.setBackgroundResource(R.drawable.bg_bottom_sheet_handle); | ||
| ViewGroup handle=new FrameLayout(activity); | ||
| handle.addView(handleView); | ||
| handle.setLayoutParams(new FrameLayout.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, V.dp(24))); |
There was a problem hiding this comment.
I didn't find where or if the AccountSwitcherSheet sets the height of the handle somewhere - setting it to 24dp manually was the only solution I could find; might be a bit hacky.
|
Already implemented but differently (tappable ALT badges in timelines). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100, #107.