Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the size of the spoiler tag #370

Closed
wants to merge 1 commit into from

Conversation

fbtw
Copy link

@fbtw fbtw commented Nov 17, 2022

Fix the size of a post with a spoiler tag before been opened when the text is longer than the spoiler tag
The problem with the blank space of the tag having the same size as the final text is some instances allow thousands of characters and the tag can occupy several pages of timeline.

Before:
before

After:
after

@grishka
Copy link
Member

grishka commented Nov 17, 2022

It is intended that the spoiler is the size of the text it hides.

@sk22
Copy link
Contributor

sk22 commented Nov 17, 2022

then there should be a maximum height imo, see #166

@waldyrious
Copy link

then there should be a maximum height imo, see #166

Alternatively, the spoiler could be positioned in a way that keeps it on-screen at all times — e.g. using sticky positioning, where it is centered when possible, but sticks to the top or bottom of the visible area if the post is too long and its center would be off-screen. This way the current effect of the spoiler area being the same size as the text it hides, as @grishka mentions, would be preserved.

@Gargron
Copy link
Member

Gargron commented Nov 28, 2022

Max height is what we do in the web app, that would be acceptable.

@GPHemsley
Copy link

It is intended that the spoiler is the size of the text it hides.

Why?

@grishka
Copy link
Member

grishka commented May 25, 2023

I'm closing this because spoilers in the Material3 redesign have a fixed height and expand into additional display items when revealed, making this issue irrelevant.
screenshot

@grishka grishka closed this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants