Move status creation to "with rss" context in accounts request spec #32020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These records are only relevant to and asserted about in the RSS section here, but they are being created for the other contexts as well. Reduces factory creation from ~170 to ~70 in this spec.
Side note - a good refactor would be to move this rss context out to it's own request spec to isolate it a bit, and then also refactor the controller actions so that we preserve the routes/endpoints, but move the implementation to like
accounts/statuses#index(for rss format) or something to better reflect the "return a bunch of rss-serialized statuses" aspect here.