Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build on Windows because addons-linter requires sharp which is hard to install on Windows #122

Closed
matatk opened this issue Nov 7, 2017 · 2 comments
Assignees
Milestone

Comments

@matatk
Copy link
Owner

matatk commented Nov 7, 2017

Can this be recommended by Landmarks, but just installed globally and used if present?

Actually, it does look possible to install fairly easily on Windows though does require Admin, and most people who fork/download this might just want to build it to run locally?

But then I get Error: `msbuild` failed with exit code: 1.

@matatk matatk added this to the 2.2.0 milestone Nov 7, 2017
@matatk matatk self-assigned this Nov 7, 2017
@matatk matatk added enhancement and removed bug labels Nov 13, 2017
@matatk
Copy link
Owner Author

matatk commented Nov 13, 2017

Oddly this problem seems to have disappeared now.

However, it is a good idea to add the easy method for installing node-gyp [actually the Windows build tools + Python] on Windows to the README, so leaving this open for now.

@matatk
Copy link
Owner Author

matatk commented Jan 19, 2018

addons-linter has removed the sharp dependency.

@matatk matatk closed this as completed Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant