Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch dependency to probe-image-size #1689

Merged
merged 4 commits into from
Dec 5, 2017
Merged

Conversation

asamuzaK
Copy link
Contributor

@asamuzaK asamuzaK commented Dec 5, 2017

Fixes #1668, #1669

'sharp' requires Python executable when installing, but Python is not installed by default on Windows, so we should replace 'sharp' to something else.

Fixed SVG icon size mismatch warning too.

Thanks for opening a Pull Request (PR), here's a few guidelines as to what we need in your PR before we review it.

Please delete anything that isn't relevant to your patch.

  • [✓] This PR relates to an existing open issue and there are no existing
    PRs open for the same issue.
  • [✓] Add Fixes #ISSUENUM at the top of your PR.
  • [✓] Add a description of the the changes introduced in this PR.
  • [✓] The change has been successfully run locally.
  • [✓] Add tests to cover the changes added in this PR.

Once you have met the above requirements please replace this section with
a Fixes #ISSUENUM linking to the issue fixed by this PR along with an
explanation of the changes. Thanks for your contribution!

Copy link
Contributor

@EnTeQuAk EnTeQuAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot for the change!

cc @rpl and @kumar303

I'll release this asap

@EnTeQuAk EnTeQuAk merged commit c64b941 into mozilla:master Dec 5, 2017
@EnTeQuAk EnTeQuAk added this to the 2017.12.07 milestone Dec 5, 2017
@asamuzaK asamuzaK deleted the probe-image branch December 5, 2017 08:43
@kumar303
Copy link
Contributor

kumar303 commented Dec 5, 2017

Thanks @asamuzaK !

@rpl
Copy link
Member

rpl commented Dec 5, 2017

@asamuzaK thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install addons-linter anymore if python is not installed
4 participants