Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AuthenticationService and UserService implementation #1068

Closed
wants to merge 4 commits into from

Conversation

SIPervii
Copy link

  • Implement findByEmail method in UserService to search for a user by email from the static array of users.
  • Correct the login method in AuthenticationService to use UserService for email lookup and validate the provided password.
  • Remove duplicate login method in AuthenticationService.
  • Ensure correct logic for user authentication based on email and password.

This fix ensures the correct functioning of the login process, and the main method now passes all test cases as expected.

- Implement findByEmail method in UserService to search for a user by email from the static array of users.
- Correct the login method in AuthenticationService to use UserService for email lookup and validate the provided password.
- Remove duplicate login method in AuthenticationService.
- Ensure correct logic for user authentication based on email and password.

This fix ensures the correct functioning of the login process, and the main method now passes all test cases as expected.
- Implement findByEmail method in UserService to search for a user by email from the static array of users.
- Correct the login method in AuthenticationService to use UserService for email lookup and validate the provided password.
- Remove duplicate login method in AuthenticationService.
- Ensure correct logic for user authentication based on email and password.

This fix ensures the correct functioning of the login process, and the main method now passes all test cases as expected.
Copy link

@MentorMateAcademy MentorMateAcademy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is implemetnation of User Service?

…nto hm-2-solution

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
# Друга спроба відправити домашне завдання <------
@SIPervii
Copy link
Author

Чому другий раз відхилили?

…nto hm-2-solution

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
# Delete comment
@SIPervii SIPervii closed this by deleting the head repository Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants