add methods login and findByEmail 2 #605
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andriy-dz
suggested changes
Jul 26, 2023
Comment on lines
3
to
4
| // import mate.academy.model.User; | ||
|
|
| @@ -11,6 +13,7 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| return false; | |||
| UserService member = new UserService(); | |||
| return member.findByEmail(email) != null && member.findByPassword(password) != null; | |||
There was a problem hiding this comment.
is the logic here correct?) Can there be such a situation that the copier did not enter his password, but that password exists in the database with another user. In this case, your program will skip the user and it will not be very true. I suggest limiting yourself to one getByEmail method and getting the password from the User and comparing it with what was entered at the entrance)
Andriy-dz
approved these changes
Jul 31, 2023
| } | ||
| } | ||
|
|
| return null; | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.