-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Xres extension before using it. #747
Conversation
My crystal ball is broken, for what is your PR good for ? |
:) It is related to #746 Quote from man page:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This builds and runs fine with marco in both compositing and noncomposing mode. Note that runtime test was short as I normally run compiz. Didn't get any issues with windows overlapping panels or anything like that.
NOT tested with X2go however as I simply don't have that sort of setup
Marco does not use libwnck... |
Before using any Xres extension one must call XResQueryExtension() Also make sure Xres 1.2 is available as marco need XResQueryClientIds()
Needed for X2Go as it does not have XRES 1.2 extension.
0effb64
to
6cc8a2f
Compare
Turns out that X2Go does not tolerate any call to XResQueryClientIds(). |
What is the status of this? It is ready to go? |
So this needs more work before merge? |
No idea, i only wanted to say that origin issue isn't fixed by this PR. |
I didn't claim it solved any flatpak issues, just X2GO. |
Thinking everyone who's going to review this already has, we have two different testers (one the writer) finding this fixes the X2go issue, and this is not about any flatpak bugs. Been almost a month and no problems caused by this have cropped up. The new variables are several Will merge |
Thank you, adding it to 1.26 too? |
I normally only work on the master branch, it's three cherrypicks to make this work but since 4 commits back also related to this will try it |
Someone else will have to handle releasing a 1.26 point release containing this: just pushed it to the branch but I have never managed the releases |
Merged to 1.26, distros won't see it until someone releases 1.26.2 |
I will do point releases soon. |
I guess my soon is different from your soon :) |
No description provided.