Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed-size notes support #641

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qmaldon
Copy link

@qmaldon qmaldon commented Sep 5, 2022

Hi all,

These changes apply to stickynotes only.

This is my first PR on a Mate repo. Please bear with me, since there are a few things that are not straightforward:

  1. Multiple changes were done automatically by the build system into .po files.
    I understand these are translation files caused by a change I did in stickynotes/sticky-notes-preferences.ui
  2. All changes were verified manually in my host (RHEL 8). I'm not sure if your CI/CD system will kick in during PR.
  3. Is there a way to get this branch backported to 1.26?

What is being enhanced & fixed:

  1. [Enhanced] Support for fixed size notes. That is, a mechanism to disallow notes resizing (on all notes).
  2. [Bug fix] On a large note (vertical length > screen height), after restarting the stickynotes applet there are no verifications of the w,h sizes stored in the xml file; as consequence no automatic scrollbar is set, leading to an ugly and difficult to manage note.
    This is fixed now, since during startup a check based on screen size is done (propagated from existed code).

Please look at the following images to get an idea of the code changes:

Screenshot from 2022-09-04 20-09-07

Screenshot from 2022-09-04 20-09-27

I decided to make these changes since the stickynotes applet has been one of my main productivity tools since 2014 (I used to run RHEL 5 at that time).

Please let me know if there is any change needed or edit as you see fit.

Thanks

Quintin Maldonado

@mbkma
Copy link
Member

mbkma commented Sep 5, 2022

Hi, thanks for contributing! Please do not change po files here. This will be overwritten by transifex anyway. To untrack po files, I belive it is
git rm -r --cached <folder>
I am not sure though.

@qmaldon qmaldon force-pushed the stickynotes-support-fixedsize branch from bcc5d40 to 37c0932 Compare September 5, 2022 19:12
@qmaldon
Copy link
Author

qmaldon commented Sep 5, 2022

Hi, thanks for contributing! Please do not change po files here. This will be overwritten by transifex anyway. To untrack po files, I belive it is git rm -r --cached <folder> I am not sure though.

Hi @mbkma ,
Removed .po changes from branch as suggested. Please have a look.

I think there is an issue in the debian build. Fedora looks good.

Is there a way to get this branch backported to 1.26?

Following up on this, perhaps it would be 1.26.2?

Thanks

Quintin Maldonado

{
note->force_fixed_size = force_fixed_size;

if (force_fixed_size) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem with the judgment here

@@ -251,6 +251,8 @@ stickynote_new_aux (GdkScreen *screen,
stickynote_set_font (note, NULL, TRUE);
stickynote_set_locked (note, FALSE);

stickynote_set_fixed_size(note, stickynotes->force_fixed_size);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add spaces and unify the code format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants