Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for v5 of the golang-jwt library #15

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

oxisto
Copy link
Contributor

@oxisto oxisto commented Mar 30, 2023

Hi,

I am one of the maintainers of http://github.com/golang-jwt/jwt. For better future maintainability, we had to change the way signing methods work slightly (see golang-jwt/jwt#278). Instead of decoding/encoding the token in the signing method, this is now done in the library itself. This should also make code in projects like this a little bit easier and cleaner.

Fixes #13

@matelang
Copy link
Owner

matelang commented Apr 1, 2023

Hi @oxisto ,

Thanks for opening this PR and for making those improvements on the golang-jwt library.
I was following also the v5 progress.

Currently I am travelling and having limited access, but I'll check this PR early next week.

Cheers!

Copy link
Owner

@matelang matelang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
When do you think it's best to merge it in? I can see the parent lib is at 5.0.0-rc2.

@oxisto
Copy link
Contributor Author

oxisto commented Apr 3, 2023

Looking good!
When do you think it's best to merge it in? I can see the parent lib is at 5.0.0-rc2.

Without any promises, we aim to release v5 around Easter, so hopefully very soon. I will update this to the latest v5 release version then

@matelang matelang added the enhancement New feature or request label Apr 3, 2023
@matelang
Copy link
Owner

matelang commented Apr 5, 2023

Hi @oxisto ,

There was another PR (adding support for PSS) which required a bit of a refactor, and I've managed to simplify the code.
If you have time could you please resolve the conflicts?

Now there is just one KMS SigningMethod since I've managed to remove code duplication.

If you want I am happy to do the changes, but I did not want to take this contrib from you.

Cheers!

For better future maintainability, we had to change the way signing methods work slightly. Instead of decoding/encoding the token in the signing method, this is now done in the library itself. This should also make code in projects like this a little bit easier and cleaner.

Fixes matelang#13
@oxisto
Copy link
Contributor Author

oxisto commented Apr 5, 2023

Hi @oxisto ,

There was another PR (adding support for PSS) which required a bit of a refactor, and I've managed to simplify the code. If you have time could you please resolve the conflicts?

Now there is just one KMS SigningMethod since I've managed to remove code duplication.

If you want I am happy to do the changes, but I did not want to take this contrib from you.

Cheers!

Merging done.

@matelang matelang merged commit 4d0c7db into matelang:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go-jwt V5 Support
2 participants