-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for v5
of the golang-jwt
library
#15
Conversation
Hi @oxisto , Thanks for opening this PR and for making those improvements on the golang-jwt library. Currently I am travelling and having limited access, but I'll check this PR early next week. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
When do you think it's best to merge it in? I can see the parent lib is at 5.0.0-rc2.
Without any promises, we aim to release v5 around Easter, so hopefully very soon. I will update this to the latest v5 release version then |
Hi @oxisto , There was another PR (adding support for PSS) which required a bit of a refactor, and I've managed to simplify the code. Now there is just one KMS SigningMethod since I've managed to remove code duplication. If you want I am happy to do the changes, but I did not want to take this contrib from you. Cheers! |
For better future maintainability, we had to change the way signing methods work slightly. Instead of decoding/encoding the token in the signing method, this is now done in the library itself. This should also make code in projects like this a little bit easier and cleaner. Fixes matelang#13
Merging done. |
Hi,
I am one of the maintainers of http://github.com/golang-jwt/jwt. For better future maintainability, we had to change the way signing methods work slightly (see golang-jwt/jwt#278). Instead of decoding/encoding the token in the signing method, this is now done in the library itself. This should also make code in projects like this a little bit easier and cleaner.
Fixes #13