Skip to content

Commit

Permalink
[Dialog] Reduce insets for Material Alert Dialog to 10dp for screens …
Browse files Browse the repository at this point in the history
…with minimum height less than h480dp.

Reducing the insets will allow for nested scroll view content to be visible enough to enable user interaction (scrolling).

PiperOrigin-RevId: 660521229
  • Loading branch information
kendrickumstattd authored and drchen committed Aug 12, 2024
1 parent 4efcf87 commit bedc6bd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 29 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

<resources>
<dimen name="mtrl_alert_dialog_background_inset_start">24dp</dimen>
<dimen name="mtrl_alert_dialog_background_inset_top">24dp</dimen>
<dimen name="mtrl_alert_dialog_background_inset_top">80dp</dimen>
<dimen name="mtrl_alert_dialog_background_inset_end">24dp</dimen>
<dimen name="mtrl_alert_dialog_background_inset_bottom">24dp</dimen>
<dimen name="mtrl_alert_dialog_background_inset_bottom">80dp</dimen>
</resources>

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,11 @@
-->

<resources>
<dimen name="mtrl_alert_dialog_background_inset_start">24dp</dimen>
<dimen name="mtrl_alert_dialog_background_inset_top">80dp</dimen>
<dimen name="mtrl_alert_dialog_background_inset_end">24dp</dimen>
<dimen name="mtrl_alert_dialog_background_inset_bottom">80dp</dimen>
<!-- Inset values for devices with a small height; the true default inset values are in res/values-h480dp -->
<dimen name="mtrl_alert_dialog_background_inset_start">10dp</dimen>
<dimen name="mtrl_alert_dialog_background_inset_top">10dp</dimen>
<dimen name="mtrl_alert_dialog_background_inset_end">10dp</dimen>
<dimen name="mtrl_alert_dialog_background_inset_bottom">10dp</dimen>
<!-- 16dp from abc_dialog_material_background.xml -->
<dimen name="appcompat_dialog_background_inset">16dp</dimen>

Expand Down

0 comments on commit bedc6bd

Please sign in to comment.