Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up API documentation #559

Merged
merged 7 commits into from
Jul 27, 2021
Merged

Conversation

wd15
Copy link
Contributor

@wd15 wd15 commented Jul 20, 2021

No description provided.

 - Fix links to examples in README.md
 - Add graph-descriptors.ipynb to notebooks in documentation
 - Fix maths in two_point_stats and correlations_multiple
 - Add more useful documentation for coeff_to_real
 - Add complete documentation for solve_fe
 - Add complete documentation for solve_cahn_hilliard
 - Small changes to other API functions
@wd15 wd15 requested a review from beyucel July 20, 2021 18:11
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wd15 wd15 requested a review from auag92 July 20, 2021 18:11
@wd15 wd15 added this to the 0.4.1 milestone Jul 20, 2021
plot_microstructures now returns the fig object, but we don't want
being rendered in the notebook so using a ";" to prevent it.
@wd15
Copy link
Contributor Author

wd15 commented Jul 20, 2021

@beyucel @auag92 please look at the new API docs to review this. There is plenty more to add to the API documentation and lots of ways to improve it. Check that there are no glaring issues and try and document anything else you notice in issues. Also, there is now a reviewnb link above which allows you to review notebooks and those reviews will get posted here.

@wd15 wd15 merged commit f76681a into materialsinnovation:master Jul 27, 2021
@wd15 wd15 deleted the issue547-api branch July 27, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant