Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect type hint for run_id in builder_meta #1068

Merged
merged 1 commit into from
Aug 1, 2024
Merged

incorrect type hint for run_id in builder_meta #1068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions emmet-core/emmet/core/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@

"""Base emmet model to add default metadata."""

from typing import Literal, Optional, TypeVar

from datetime import datetime
from typing import Literal, Optional, TypeVar

from pydantic import BaseModel, Field, field_validator
from pymatgen.core import __version__ as pmg_version
Expand All @@ -26,7 +25,7 @@ class EmmetMeta(BaseModel):
pmg_version, description="The version of pymatgen this document was built with."
)

run_id: Optional[int] = Field(
run_id: Optional[str] = Field(
None, description="The run id associated with this data build."
)

Expand Down