Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dielectric + optical absorption coeff to CalculationOutput model #1070

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

tsmathis
Copy link
Collaborator

@tsmathis tsmathis commented Aug 6, 2024

Doc model for CalculationOutput was missing fields from output of optical calc workflows

@tsmathis tsmathis added Core Any updates for Emmet-Core pydantic pydantic-related PRs and issues labels Aug 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.96%. Comparing base (578f615) to head (d463481).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1070      +/-   ##
==========================================
- Coverage   90.00%   88.96%   -1.05%     
==========================================
  Files         143      114      -29     
  Lines       13428    10345    -3083     
==========================================
- Hits        12086     9203    -2883     
+ Misses       1342     1142     -200     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmathis tsmathis merged commit 8b23a06 into main Aug 6, 2024
7 checks passed
@tsmathis tsmathis deleted the optical-wf-fields branch August 6, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Any updates for Emmet-Core pydantic pydantic-related PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants