Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logic bug in batch_id validatoin #1091

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

tsmathis
Copy link
Collaborator

@tsmathis tsmathis commented Sep 9, 2024

or -> and, easy oversight

  • rm newline character from output

@tsmathis tsmathis added bug Core Any updates for Emmet-Core pydantic pydantic-related PRs and issues labels Sep 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.03%. Comparing base (8db3189) to head (d8031dc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1091   +/-   ##
=======================================
  Coverage   90.03%   90.03%           
=======================================
  Files         147      147           
  Lines       13460    13460           
=======================================
  Hits        12119    12119           
  Misses       1341     1341           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmathis tsmathis merged commit 3b414c6 into main Sep 9, 2024
6 of 7 checks passed
@tsmathis tsmathis deleted the batch_id-validation-bug branch September 9, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Core Any updates for Emmet-Core pydantic pydantic-related PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants