Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qchem enums #1092

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Qchem enums #1092

merged 2 commits into from
Sep 10, 2024

Conversation

tsmathis
Copy link
Collaborator

@tsmathis tsmathis commented Sep 9, 2024

adds qchem enums back that were removed in #926

@tsmathis tsmathis linked an issue Sep 9, 2024 that may be closed by this pull request
3 tasks
@tsmathis tsmathis added the Core Any updates for Emmet-Core label Sep 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.46%. Comparing base (3b414c6) to head (999aac2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
+ Coverage   90.03%   90.46%   +0.43%     
==========================================
  Files         147      147              
  Lines       13460    14133     +673     
==========================================
+ Hits        12119    12786     +667     
- Misses       1341     1347       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmathis tsmathis merged commit 530ec4f into main Sep 10, 2024
6 of 7 checks passed
@tsmathis tsmathis deleted the qchem_enums branch September 10, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Any updates for Emmet-Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Molecules calc types still trying to import missing enums
2 participants