Return path to decompressed file from decompress_file()
#536
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #536 +/- ##
=========================================
Coverage ? 76.49%
=========================================
Files ? 27
Lines ? 1523
Branches ? 320
=========================================
Hits ? 1165
Misses ? 297
Partials ? 61 ☔ View full report in Codecov by Sentry. |
|
@janosh: This seems like it was perhaps a breaking change. Could you take a look at https://github.com/Quantum-Accelerators/quacc/actions/runs/5790005449/job/15692210083?pr=660 and see if it seems related? |
|
@janosh: Yeah, actually, seems like this introduce a bug. If the file extension isn't in A better solution would be to have it return |
| for f in files: | ||
| compress_file(os.path.join(parent, f), compression=compression) | ||
|
|
||
|
|
||
| def decompress_file(filepath): | ||
| def decompress_file(filepath) -> str: |
There was a problem hiding this comment.
@janosh: Change this to str | None
| f_out.writelines(f_in) | ||
| os.remove(filepath) | ||
|
|
||
| return out_file |
There was a problem hiding this comment.
@janosh: move this return inside the if statement so that it only returns the string if it's decompressing a file. Otherwise, have it return None (as before).
Needed for materialsproject/pymatgen#3192 (comment).