rat is countable #435
Closed
rat is countable #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affeldt-aist
force-pushed
the
countable_rat
branch
from
0155b21
to
4fbf02a
Compare
CohenCyril
reviewed
Sep 22, 2021
Comment on lines
+49
to
+50
| (* nat_of_rat == injection from rat to nat *) | ||
| (* rat_of_nat == cancel function for nat_of_rat *) |
There was a problem hiding this comment.
Note that pickle and unpickle already do that...
https://github.com/math-comp/math-comp/blob/6c66f38e8312624d866050284ec2591e85c96c11/mathcomp/ssreflect/choice.v#L14-L15
CohenCyril
reviewed
Sep 22, 2021
| @@ -57,7 +58,7 @@ Unset Printing Implicit Defensive. | |||
| Reserved Notation "'`I_' n" (at level 8, n at level 2, format "'`I_' n"). | |||
| Reserved Notation "A '#<=' B" (at level 79, format "A '#<=' B"). | |||
|
|
|||
| Import Order.TTheory. | |||
| Import Order.TTheory GRing.Theory. | |||
There was a problem hiding this comment.
This import does not have to be in the begining, it can be contained in a section.
proux01
reviewed
Sep 22, 2021
| @@ -45,6 +45,9 @@ | |||
| - in `normedtype.v`: | |||
| + lemmas `ereal_is_cvgN`, `ereal_cvgZr`, `ereal_is_cvgZr`, `ereal_cvgZl`, `ereal_is_cvgZl`, | |||
| `ereal_limZr`, `ereal_limZl`, `ereal_limN` | |||
| - in `cardinality.v`: | |||
| + definitions `pair_of_nat`, `nat_of_rat`, `rat_of_nat` | |||
There was a problem hiding this comment.
Suggested change
| + definitions `pair_of_nat`, `nat_of_rat`, `rat_of_nat` | |
| + definitions `nat_of_pair`, `nat_of_rat`, `rat_of_nat` |
affeldt-aist
force-pushed
the
countable_rat
branch
from
4fbf02a
to
4f74c31
Compare
CohenCyril
force-pushed
the
countable_rat
branch
2 times, most recently
from
f9b5f0f
to
107c6b3
Compare
CohenCyril
force-pushed
the
countable_rat
branch
2 times, most recently
from
b6361a9
to
3e2e42b
Compare
- remove lemmas from documentation - replace cases on boolP with eqVneq when possible - replace O with 0%N
affeldt-aist
force-pushed
the
countable_rat
branch
from
3e2e42b
to
2295676
Compare
|
Closed by #543 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions between nat and rat are used to establish measurability of a (countable) union over the set of rationals
in the formalization of measure theory.