-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NES in HB #144
base: master
Are you sure you want to change the base?
NES in HB #144
Conversation
Please open an issue saying to remove this when we decide to require a more recent coq-elpi |
It's not about upgrading to a more recent coq-elpi (yet), it's about adding the |
I need to make a PR in coq-elpi to add this feature though, and you will be right ;) |
Done cf LPCIC/coq-elpi#212 |
Another problem I have with this is that "logging" is something I'm implementing in HB. And we definitely want calls to NES to be replaced by vernacular commands in plan-B, so I think we should Accumulate this file together with hb.elpi and hook into the logging infrastructure (in the other PR) |
I do not understand completely, shouldn't NES have its own logging infrastructure and incorporated in LPCIC/coq-elpi#212? |
It could, but I did deliberately not put the logging code in coq-elpi because it is too experimental. You are right that its place is there, but it is not ready. The plan was to let it mature inside HB and only then move it back to coq-elpi. |
No description provided.