Skip to content

Commit

Permalink
Remove redundant compatibility usage of importlib_metadata (apache#38368
Browse files Browse the repository at this point in the history
)
  • Loading branch information
Taragolis authored and Mathia Haure-Touze committed Apr 4, 2024
1 parent c2772d3 commit 84b99fc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 13 deletions.
8 changes: 2 additions & 6 deletions airflow/providers/docker/hooks/docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
from __future__ import annotations

import json
import sys
import warnings
from functools import cached_property
from typing import TYPE_CHECKING, Any
Expand Down Expand Up @@ -105,12 +104,9 @@ def construct_tls_config(
:param ssl_version: Version of SSL to use when communicating with docker daemon.
"""
if ca_cert and client_cert and client_key:
from packaging.version import Version
from importlib.metadata import version

if sys.version_info >= (3, 9):
from importlib.metadata import version
else:
from importlib_metadata import version
from packaging.version import Version

tls_config = {
"ca_cert": ca_cert,
Expand Down
8 changes: 1 addition & 7 deletions tests/providers/docker/hooks/test_docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@

import logging
import ssl
import sys
import warnings
from importlib.metadata import version
from unittest import mock

import pytest
Expand All @@ -31,12 +31,6 @@
from airflow.exceptions import AirflowException, AirflowNotFoundException
from airflow.providers.docker.hooks.docker import DockerHook

if sys.version_info >= (3, 9):
from importlib.metadata import version
else:
from importlib_metadata import version


DOCKER_PY_7_PLUS = Version(Version(version("docker")).base_version) >= Version("7")

TEST_CONN_ID = "docker_test_connection"
Expand Down

0 comments on commit 84b99fc

Please sign in to comment.