Switch to using Zopfli file output and moving/renaming to destination… #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this PR has to run through the tests again as the original repo has changed from Googlecode to GitHub (and therefore currently fails). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #18, where output of this task was corrupted on Windows machines. Should probably be tested on Linux and Mac before committing.
I tried a few alternatives to get the stdout stream to work on Windows, but was unsuccessful, I suspect because Node simply doesn't understand systems which don't use UTF-8 for std/console output. However this works fine and I don't really see any downsides.