Implement support for && and || in v sets
#52
Conversation
rewrite-pattern.js
Outdated
| @@ -312,17 +402,20 @@ const regjsparserFeatures = { | |||
| 'unicodePropertyEscape': true, | |||
| 'namedGroups': true, | |||
| 'lookbehind': true, | |||
| 'unicodeSet': true, | |||
There was a problem hiding this comment.
This shouldn't be enabled by default
nicolo-ribaudo
force-pushed
the
set-notation
branch
2 times, most recently
from
ac2e643
to
665b2d8
Compare
nicolo-ribaudo
force-pushed
the
set-notation
branch
from
665b2d8
to
8c26775
Compare
rewrite-pattern.js
Outdated
| @@ -363,21 +462,34 @@ const rewritePattern = (pattern, flags, options) => { | |||
| validateOptions(options); | |||
|
|
|||
| config.flags.unicode = hasFlag(flags, 'u'); | |||
| config.flags.unicodeSet = hasFlag(flags, 'v'); | |||
There was a problem hiding this comment.
Let’s continue matching the RegExp.prototype getter name, which in this case is unicodeSets.
rewrite-pattern.js
Outdated
| // unicodeFlag: 'transform' implies unicodePropertyEscapes: 'transform' | ||
| config.transform.unicodePropertyEscapes = config.flags.unicode && ( | ||
| transform(options, 'unicodeFlag') || transform(options, 'unicodePropertyEscapes') | ||
| ); | ||
| config.transform.namedGroups = transform(options, 'namedGroups'); | ||
|
|
||
| const regjsparserFeatures = { | ||
| 'unicodeSet': Boolean(options && options.unicodeSetFlag), |
There was a problem hiding this comment.
Perhaps unicodeSets here too, for consistency?
There was a problem hiding this comment.
This is a regjsparser option, so we could change it when it has a breaking release. However, it also uses unicodePropertyEscape so it's consistent with itself.
tests/tests.js
Outdated
| }, | ||
| ]; | ||
|
|
||
| describe('unicode set (v) flag', () => { |
There was a problem hiding this comment.
| describe('unicode set (v) flag', () => { | |
| describe('unicodeSets (v) flag', () => { |
tests/tests.js
Outdated
| @@ -1001,3 +1001,134 @@ describe('character classes', () => { | |||
| } | |||
| }); | |||
|
|
|||
| const TRANSFORM_U = { unicodeFlag: 'transform', unicodeSetFlag: 'transform' }; | |||
There was a problem hiding this comment.
I’m confused by this combination of settings, so just to clarify:
- The grammar for the
uflag does not change with thevflag proposal. - Only the
vflag enables the new functionality. - The two flags cannot be combined.
There was a problem hiding this comment.
I updated the readme, hopefully it makes it clear. By default v is transformed to u, but you can set unicodeFlag: 'transform' to transform it even more. This is a sensible default, because now many browsers support u natively.
We also do something similar in Babel, where class fields are transformed to ES6 classes and then you can choose to transform them even more to ES5.
nicolo-ribaudo
force-pushed
the
set-notation
branch
from
f43e4b0
to
e6ef9a5
Compare
This adds support for
&&and||. It doesn't support string alternatives in sets ([\q{ab|cd}]) or the updates to\p: I'll open other PRs for them.I'm marking this as a wip because: