Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm_move update #1023

Merged
merged 5 commits into from
Nov 23, 2023
Merged

pnpm_move update #1023

merged 5 commits into from
Nov 23, 2023

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Nov 20, 2023

This PR makes the changes that we discussed face-to-face:

  • The makeAll script is modified to not cd to the component directories, but rather passes the directory to the various programs as their last argument. This avoids the problem that you fixed in the pack command, in particular.

  • The package scripts are modified:

    • The \e escape is replaced by \x1B since MacOS ships with an older bash version that doesn't support that.
    • The color was changed from 32 (yellow) to 34 (blue) in log:single, and -- was added to help make it visually distinct (especially when log:comp is used before it)`.
    • The cjs and mjs names were moved to the front of their commands to make the sections each use a prefix.
    • The mml3 XSLT commands were modified to use an mml3: prefix like the other sections
    • The cleaning of the bundle-cjs directory was moved earlier in the clean command so that the log messages are in a more appropriate order.

@dpvc dpvc requested a review from zorkow November 20, 2023 15:35
@dpvc dpvc added this to the v4.0 milestone Nov 20, 2023
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could go one step further with our naming convention and do:

cjs:components:clean...
cjs:components:build...
...
cjs:bundle:clean ...

What do you think?

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The \x1B change does not work for me. I'll look into it what we could use instead.

package.json Outdated Show resolved Hide resolved
@zorkow
Copy link
Member

zorkow commented Nov 22, 2023

The \x1B change does not work for me. I'll look into it what we could use instead.

@dpvc can you try this line, if the \033 escape code works for you?

    "log:test": "log() { echo \\\\033[33m hello world \\\\033[0m; }; log",

Source: Stackoverflow

@dpvc
Copy link
Member Author

dpvc commented Nov 22, 2023

We could go one step further with our naming convention

Sounds good. Go ahead with that.

can you try this line, if the \033 escape code works for you?

Yes, it does. That was going to be my suggestion as well.

Co-authored-by: Volker Sorge <[email protected]>
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll go ahead and merge.

@zorkow zorkow merged commit 6436642 into pnpm_move Nov 23, 2023
@zorkow zorkow deleted the pnpm-update branch November 23, 2023 15:24
@zorkow zorkow mentioned this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants