-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pnpm_move update #1023
pnpm_move update #1023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could go one step further with our naming convention and do:
cjs:components:clean...
cjs:components:build...
...
cjs:bundle:clean ...
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The \x1B
change does not work for me. I'll look into it what we could use instead.
@dpvc can you try this line, if the
|
Sounds good. Go ahead with that.
Yes, it does. That was going to be my suggestion as well. |
Co-authored-by: Volker Sorge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'll go ahead and merge.
This PR makes the changes that we discussed face-to-face:
The
makeAll
script is modified to not cd to the component directories, but rather passes the directory to the various programs as their last argument. This avoids the problem that you fixed in thepack
command, in particular.The package scripts are modified:
\e
escape is replaced by\x1B
since MacOS ships with an older bash version that doesn't support that.log:single
, and--
was added to help make it visually distinct (especially whenlog:comp
is used before it)`.cjs
andmjs
names were moved to the front of their commands to make the sections each use a prefix.mml3:
prefix like the other sectionsbundle-cjs
directory was moved earlier in theclean
command so that the log messages are in a more appropriate order.