Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle pnpm node_module paths better in [node] prefix in messages #1077

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 24, 2024

This is a small PR to improve the output from the components/bin/pack command for reporting files included from the node_modules directory. Since pnpm uses symbolic links, the filenames reported are not as concise as they could be. This alters the regex pattern used for the [node] prefix to collapse .pnpm links for shorter file names.

@dpvc dpvc requested a review from zorkow March 24, 2024 22:35
@dpvc dpvc added this to the v4.0 milestone Mar 24, 2024
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit e13e13c into develop Mar 26, 2024
@dpvc dpvc deleted the pack-messages branch March 26, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants