Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Adding LaTeX subexpressions into the tree #986

Closed
wants to merge 36 commits into from

Conversation

zorkow
Copy link
Member

@zorkow zorkow commented Aug 14, 2023

The PR computes and adds corresponding LaTeX commands to subexpressions in a latex attribute. This allows SRE to generate Euro Braille.

  • We mainly keep pointers to the start and end of a command in the main parser.
  • For environments and commands we use two auxiliary attributes to collate LaTeX expressions: latex and itemLatex in BaseItem. The latter retains information on the current command or environment, the former can be overwritten when more of the actual LaTeX command is completed.
  • Care has to be taken when computing sub- and superscripts.

Please note the following:

  • I have left the latex attribute in place for the time being as this is what the current version of SRE expects. We can update that to data-mjx-latex with the next version of SRE.
  • I have also changed default Braille setting from Nemeth to Euro for better testing. However, we can change that back before the next release.

dpvc and others added 30 commits September 20, 2022 21:47
@zorkow zorkow requested a review from dpvc August 14, 2023 16:34
@zorkow zorkow marked this pull request as ready for review August 14, 2023 16:37
@zorkow
Copy link
Member Author

zorkow commented Aug 14, 2023

I also note that the PR contains a number of odd commits from @dpvc . Maybe because I branched this off of the alpha release?

@dpvc
Copy link
Member

dpvc commented Sep 15, 2023

I've made a new branch sre-latex-braille-ext (using - rather than _ so you can tell it is from me) that is based off of the current develop branch, and where I cherry-picked the individual entries from the original branch. This takes the 4.0.0-alpha branch out of the picture, eliminating the unwanted commits from that branch. If I merge develop into the original SRE branch, then the results show no differences, so I think I did it OK, but you might want to check it to make sure that it is correct. If you are happy with is, make a PR based off that branch, and close this one.

I suspect we will need to do the same for the explorer rewrite branch, since it has also merges 4.0.0-alpha (and the original SRE LaTeX branch), in order to get a clean PR onto the new SRE branch.

@zorkow zorkow mentioned this pull request Sep 18, 2023
@zorkow
Copy link
Member Author

zorkow commented Sep 19, 2023

Superseded by PR #1004

@zorkow zorkow closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants