Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for tests:check-direct-dependency-use command, #PG-3272 #778

Open
wants to merge 4 commits into
base: live
Choose a base branch
from

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Added documentation for tests:check-direct-dependency-use command
Fixes: #PG-3272

Review

@michalkleiner
Copy link
Contributor

Nice start, thanks @AltamashShaikh!

Can we add a note why this might be useful to do? Why would plugin developers want to do this and if they find using core dependencies, what they can do about it?

@AltamashShaikh
Copy link
Contributor Author

@michalkleiner Can you check now ?

@michalkleiner
Copy link
Contributor

Generally looking ok, just some minor tweaks/suggestions.
We will merge this when 5.1.0-beta1 is released.

@AltamashShaikh
Copy link
Contributor Author

@michalkleiner Applied all the feedback.

@michalkleiner
Copy link
Contributor

Thanks, I guess we shall wait for 5.1.0-beta1 release and then we can merge this documentation PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants