Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds some tests around correct handling of formulas in CSV export #22658

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 10, 2024

Description:

applies #22646 to 4.x-dev

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Oct 10, 2024
@sgiehl sgiehl added this to the 4.16.2 milestone Oct 10, 2024
@sgiehl sgiehl requested a review from a team October 10, 2024 07:31
* Improve escaping of values in CSV exports

* adjust tests
@sgiehl sgiehl requested a review from mneudert October 10, 2024 08:59
@sgiehl sgiehl force-pushed the apply22646 branch 4 times, most recently from e0c65ab to 2a4e076 Compare October 11, 2024 15:59
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sgiehl sgiehl merged commit 027355b into 4.x-dev Oct 14, 2024
25 of 50 checks passed
@sgiehl sgiehl deleted the apply22646 branch October 14, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants