Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: remove _hold shims to support basemap + cartopy #12753

Merged
merged 1 commit into from
Nov 11, 2018

Conversation

tacaswell
Copy link
Member

The putter was added in 3.0.1 to fix all released versions of cartopy.
The setter was added in 3.0.2 to fix basemap's handling of the API
change.

All are being removed for 3.1

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

The putter was added in 3.0.1 to fix all released versions of cartopy.
The setter was added in 3.0.2 to fix basemap's handling of the API
change.

All are being removed for 3.1
@tacaswell tacaswell added this to the v3.1 milestone Nov 5, 2018
@WeatherGod
Copy link
Member

Has cartopy fixed this issue in their master branch, yet? If so, I am fine with finally removing _hold.

@QuLogic
Copy link
Member

QuLogic commented Nov 6, 2018

No, SciTools/cartopy#1130 is waiting for @dopplershift to finish conda-forge/matplotlib-feedstock#181 so we can test things properly.

@dopplershift
Copy link
Contributor

Top of the list as soon as unbury from my trip last week.

@dstansby
Copy link
Member

Since the two issues linked by @QuLogic are merged, I figure this is good to go.

@dstansby dstansby merged commit 86a4bc7 into matplotlib:master Nov 11, 2018
@dopplershift
Copy link
Contributor

Mostly. Technically, CartoPy still needs to release those fixes, but I promise to cut that release on Friday. 😁

@tacaswell
Copy link
Member Author

but I promise to cut that release on Friday. grin

Applying my usual discount rate to time estimations, next Friday ;)

@tacaswell tacaswell deleted the fix_remove_hold_shims branch November 11, 2018 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants