MAINT: Add api-token for CircleCI redirector action #25672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Apr 12, 2023
Co-authored-by: Thomas A Caswell <[email protected]>
|
I don't know if that helps or not - we are failing way earlier when we try and install codecov? |
|
Can you drop codecov/coverage here? Re: https://matrix.to/#/!BXmyZMTnRjWJldDRLV:gitter.im/$_KoAHkkUoHKgNSvjo0ByDF0XZWwSXJaErOodoYzi8AQ?via=gitter.im&via=matrix.org&via=aria-net.org |
|
Ok - I think this is ready (I don't think the CI failures are related). This will only work once merged to main - you can see similar work done here: scipy/scipy#18292 |
This was referenced Apr 13, 2023
Merged
QuLogic
approved these changes
Apr 13, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 13, 2023
QuLogic
added a commit
that referenced
this pull request
Apr 13, 2023
…672-on-v3.7.x Backport PR #25672 on branch v3.7.x (MAINT: Add api-token for CircleCI redirector action)
|
@meeseeksdev backport to v3.7.1-doc |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 17, 2023
oscargus
added a commit
that referenced
this pull request
Apr 17, 2023
…672-on-v3.7.1-doc Backport PR #25672 on branch v3.7.1-doc (MAINT: Add api-token for CircleCI redirector action)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The CircleCI artifact redirector action (which creates the docs preview links in PRs) is failing. This is due to an upstream bug. Following the advice on that thread, this PR adds the
api-tokendefinition in the configuration file for the action.PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst