Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search_works_across_an_upgraded_room_and_its_predecessor is flaky #478

Closed
DMRobertson opened this issue Sep 20, 2022 · 7 comments · Fixed by #479
Closed

Search_works_across_an_upgraded_room_and_its_predecessor is flaky #478

DMRobertson opened this issue Sep 20, 2022 · 7 comments · Fixed by #479

Comments

@DMRobertson
Copy link
Contributor

https://github.com/matrix-org/synapse/actions/runs/3081667619/jobs/4982001564

Ported from sytest in #464
@H-Shay
Copy link
Contributor

H-Shay commented Sep 20, 2022

Should this be tracked here or in complement? I didn't see any notes about this in the minutes, was there a decision made about it?

@DMRobertson
Copy link
Contributor Author

Minutes updated, but TL;DR

  • if we suspect a Synapse bug/race, raise in Synapse
  • if we think a test is just plain wrong, raise in complement

@DMRobertson
Copy link
Contributor Author

https://github.com/matrix-org/synapse/actions/runs/3110974464/jobs/5042735159#step:4:5929

@richvdh
Copy link
Member

richvdh commented Sep 26, 2022

The problem here is that the complement test is assuming that the search results will be returned in a particular order, which I don't think is correct (and certainly the sytest that it was ported from did not make that assumption).

The problem is, I'm not really sure how best to express that in Complement.

@richvdh richvdh transferred this issue from matrix-org/synapse Sep 26, 2022
@richvdh richvdh changed the title Suspected flake: Search_works_across_an_upgraded_room_and_its_predecessor Search_works_across_an_upgraded_room_and_its_predecessor is flaky Sep 26, 2022
@richvdh
Copy link
Member

richvdh commented Sep 26, 2022

if we think a test is just plain wrong, raise in complement

Moving to the complement repo, then.

@richvdh
Copy link
Member

richvdh commented Sep 26, 2022

https://github.com/matrix-org/synapse/actions/runs/3130081166/jobs/5079975834

@richvdh richvdh mentioned this issue Sep 26, 2022
Merged
@DMRobertson
Copy link
Contributor Author

Another one here: https://github.com/matrix-org/synapse/actions/runs/3126059365/jobs/5071114994

@DMRobertson DMRobertson mentioned this issue Sep 27, 2022
Closed
richvdh added a commit that referenced this issue Sep 27, 2022
@richvdh
Allow search results to appear in multiple orders
a98d9e4 
Fixes #478, I hope, though there
may be other tests with the same problem.
@richvdh richvdh mentioned this issue Sep 27, 2022
Merged
richvdh added a commit that referenced this issue Sep 27, 2022
@richvdh
Allow search results to appear in multiple orders (#479)
c04aeb6 
Fixes #478, I hope, though there
may be other tests with the same problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow search results to appear in multiple orders matrix-org/complement
3 participants
@richvdh @DMRobertson @H-Shay