Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complement TestDeviceListUpdates/when_joining_a_room_with_a_remote_user is flakey #580

Closed
DMRobertson opened this issue Sep 29, 2022 · 7 comments · Fixed by #593
Closed

Complement TestDeviceListUpdates/when_joining_a_room_with_a_remote_user is flakey #580

DMRobertson opened this issue Sep 29, 2022 · 7 comments · Fixed by #593
Assignees
@squahtx
Labels
Z-Flake

Comments

@DMRobertson
Copy link
Contributor

https://github.com/matrix-org/synapse/actions/runs/3149623842/jobs/5121449618#step:5:8174

Happened in worker mode---would guess there's some race the test isn't expecting?
@DMRobertson DMRobertson mentioned this issue Sep 29, 2022
Closed
@squahtx
Copy link
Contributor

squahtx commented Sep 29, 2022

related to matrix-org/synapse#13783

@squahtx
Copy link
Contributor

squahtx commented Sep 29, 2022

I reckon the tests are picking up the spurious device_lists.changed instead of the real one and advancing too early.

@squahtx squahtx changed the title Complement when_joining_a_room_with_a_remote_user is flakey(?) Complement TestDeviceListUpdates/when_joining_a_room_with_a_remote_user is flakey(?) Oct 3, 2022
@squahtx squahtx mentioned this issue Oct 7, 2022
Closed
@squahtx
Copy link
Contributor

squahtx commented Nov 14, 2022

https://github.com/matrix-org/synapse/actions/runs/3450144893/jobs/5758547133

@squahtx squahtx mentioned this issue Nov 14, 2022
Closed
@DMRobertson
Copy link
Contributor Author

https://github.com/matrix-org/synapse/actions/runs/3565720433/jobs/5991367935

@richvdh richvdh changed the title Complement TestDeviceListUpdates/when_joining_a_room_with_a_remote_user is flakey(?) Complement TestDeviceListUpdates/when_joining_a_room_with_a_remote_user is flakey Jan 10, 2023
@richvdh richvdh transferred this issue from matrix-org/synapse Jan 10, 2023
@richvdh
Copy link
Member

richvdh commented Jan 10, 2023

https://github.com/matrix-org/synapse/actions/runs/3884827892/jobs/6627963686

@DMRobertson DMRobertson mentioned this issue Jan 23, 2023
Merged
@DMRobertson
Copy link
Contributor Author

https://github.com/matrix-org/synapse/actions/runs/3996958036/jobs/6857752983

@DMRobertson DMRobertson mentioned this issue Jan 24, 2023
Merged
squahtx pushed a commit that referenced this issue Feb 1, 2023
Fix TestDeviceListUpdates flakes
71c5437 
When a remote user has a device list update, an entry is expected to appear in
`device_lists.changed` in the `/sync` response. The local homeserver may then
query the remote homeserver for the update. Some homeservers (Synapse) may emit
extra `device_lists.changed` updates in `/sync` responses after querying keys.

Previously, we attempted to skip over the spurious `device_lists.changed`
updates by doing another sync. This wasn't sufficient, so we make another
remote user send a device list update, and wait for that to appear.

Fixes #580.

Signed-off-by: Sean Quah <[email protected]>
@squahtx squahtx mentioned this issue Feb 1, 2023
Merged
@MatMaul MatMaul mentioned this issue Feb 1, 2023
Merged
squahtx added a commit that referenced this issue Feb 1, 2023
@squahtx
Fix TestDeviceListUpdates flakes (#593)
02c5e37 
When a remote user has a device list update, an entry is expected to appear in
`device_lists.changed` in the `/sync` response. The local homeserver may then
query the remote homeserver for the update. Some homeservers (Synapse) may emit
extra `device_lists.changed` updates in `/sync` responses after querying keys.

Previously, we attempted to skip over the spurious `device_lists.changed`
updates by doing another sync. This wasn't sufficient, so we make another
remote user send a device list update, and wait for that to appear.

Fixes #580.

Signed-off-by: Sean Quah <[email protected]>
@squahtx squahtx mentioned this issue Feb 1, 2023
Merged
@squahtx squahtx self-assigned this Feb 2, 2023
@clokep
Copy link
Member

clokep commented Feb 9, 2023

I had this fail twice yesterday on me:

https://github.com/matrix-org/synapse/actions/runs/4127804842/jobs/7131517396
https://github.com/matrix-org/synapse/actions/runs/4127804842/jobs/7131517530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squahtx squahtx

Labels
Z-Flake
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TestDeviceListUpdates flakes matrix-org/complement
4 participants
@clokep @richvdh @squahtx @DMRobertson