Add tests to verify ?chunk_id actually corresponds to an insertion event that exists (MSC2716) #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: tests/msc2716_test.go
…a composable functions
Synapse support was added in matrix-org/synapse#10498
Synapse change added in matrix-org/synapse#10552
…ersions Synapse changes added in matrix-org/synapse#10566
…ent that exists Add tests for: - matrix-org/synapse#10776
MadLittleMods
force-pushed
the
madlittlemods/msc2716-verify-params
branch
from
b42cbfd
to
09b4a4b
Compare
4 tasks
MadLittleMods
changed the title
…emods/msc2716-room-creator-existing-room-version Conflicts: tests/msc2716_test.go
…g-room-version Conflicts: tests/msc2716_test.go
MadLittleMods
changed the title
…n' into madlittlemods/msc2716-verify-params
MadLittleMods
changed the base branch from
madlittlemods/msc2716-room-creator-existing-room-version
to
master
|
@kegsay Merging as the chain of PRs is getting a little too unwieldy. I'm willing to change anything you comment about in a follow-up though ⏩
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to verify ?chunk_id actually corresponds to an insertion event that exists
Part of MSC2716
Add tests for:
?chunk_idactually corresponds to an insertion event that exists (MSC2716) synapse#10776