Faster room joins: Add happy path tests for device list tracking #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 23, 2022 18:54
squahtx
force-pushed
the
squah/faster_room_joins_device_list_tracking_incoming_1
branch
from
7526731
to
58dfb70
Compare
|
Expected to fail until the last bullet in matrix-org/synapse#12993 (comment) is resolved. |
This was referenced Sep 23, 2022
erikjohnston
approved these changes
Sep 27, 2022
2 tasks
|
Now that matrix-org/synapse#13913 is merged, this should pass? |
|
(I kicked CI) |
Yes, that's right. And it looks like it does. |
…ns_device_list_tracking_incoming_1
squahtx
deleted the
squah/faster_room_joins_device_list_tracking_incoming_1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tests device list tracking for pre-existing and new members
in partial state rooms.
In particular, we test that:
/sync'sdevice_lists.changed/left/keys/changesBest reviewed commit by commit.
The first half of the commits overlap with #473.