Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move space summaries out of "MSC land" #3096

Closed
S7evinK opened this issue Jun 1, 2023 · 1 comment
Closed

Move space summaries out of "MSC land" #3096

S7evinK opened this issue Jun 1, 2023 · 1 comment
Assignees
@swedgwood
Labels
help wanted More difficult than good-first-issue but not impossible! T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@S7evinK
Copy link
Contributor

S7evinK commented Jun 1, 2023

While we already have MSC2946, it is still needed to manually enable space summaries.
We should move it to the fitting spots (e.g. clientapi/federationapi/roomserver), given it is in the spec since version 1.2.
It's also a source of confusion for new users, having to enable the MSC manually.
@S7evinK S7evinK added help wanted More difficult than good-first-issue but not impossible! T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Jun 1, 2023
@S7evinK S7evinK changed the title Move MSC2946 out of "MSC land" Move space summaries out of "MSC land" Jun 1, 2023
@swedgwood swedgwood self-assigned this Jun 27, 2023
@swedgwood swedgwood mentioned this issue Jul 4, 2023
Merged
2 tasks
swedgwood added a commit that referenced this issue Jul 20, 2023
@swedgwood
de-MSC-ifying space summaries (MSC2946) (#3134)
9582827 
- This PR moves and refactors the
[code](https://github.com/matrix-org/dendrite/blob/main/setup/mscs/msc2946/msc2946.go)
for
[MSC2946](matrix-org/matrix-spec-proposals#2946)
('Space Summaries') to integrate it into the rest of the codebase.
- Means space summaries are no longer hidden behind an MSC flag
- Solves #3096

Signed-off-by: Sam Wedgwood <[email protected]>
@swedgwood
Copy link
Contributor

Space summaries are no longer hidden behind an MSC flag :) (#3134)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swedgwood swedgwood

Labels
help wanted More difficult than good-first-issue but not impossible! T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@S7evinK @swedgwood