Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add login fallback #3302

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Add login fallback #3302

merged 3 commits into from
Jan 17, 2024

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Jan 11, 2024

Part of #3216

The files are basically copied from Synapse, with minor changes to the called endpoints. We never seem to have had the /_matrix/static/client/login/ endpoint, this adds it.

@S7evinK S7evinK added the spec-compliance Fix something that doesn't comply with the specs label Jan 11, 2024
@S7evinK S7evinK requested a review from a team as a code owner January 11, 2024 08:37
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3a4b5f4) 65.57% compared to head (e2fb34e) 65.43%.
Report is 1 commits behind head on main.

Files Patch % Lines
setup/base/base.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3302      +/-   ##
==========================================
- Coverage   65.57%   65.43%   -0.15%     
==========================================
  Files         509      509              
  Lines       57482    57488       +6     
==========================================
- Hits        37695    37616      -79     
- Misses      15926    15990      +64     
- Partials     3861     3882      +21     
Flag Coverage Δ
unittests 50.01% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK merged commit bebf701 into main Jan 17, 2024
18 of 20 checks passed
@S7evinK S7evinK deleted the s7evink/login-fallback branch January 17, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-compliance Fix something that doesn't comply with the specs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant