Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x86 tests #3317

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Fix x86 tests #3317

merged 2 commits into from
Jan 29, 2024

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Jan 29, 2024

x86 tests broke with #3298
(Not exactly the tests modified here, but TestMessageHistoryVisibility)

@S7evinK S7evinK added the T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. label Jan 29, 2024
@S7evinK S7evinK requested a review from a team as a code owner January 29, 2024 18:48
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87f028d) 65.55% compared to head (f0105ae) 65.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3317      +/-   ##
==========================================
- Coverage   65.55%   65.52%   -0.03%     
==========================================
  Files         510      510              
  Lines       57595    57595              
==========================================
- Hits        37757    37740      -17     
- Misses      15968    15986      +18     
+ Partials     3870     3869       -1     
Flag Coverage Δ
unittests 50.01% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK merged commit a3a18fb into main Jan 29, 2024
19 of 20 checks passed
@S7evinK S7evinK deleted the s7evink/x86-tests branch January 29, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants