Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Add /_synapse/admin/v1/event_reports endpoint #3342

Merged
merged 11 commits into from
Mar 22, 2024
Merged

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Mar 21, 2024

Based on #3340

This adds a /_synapse/admin/v1/event_reports endpoint, the same Synapse has. This way existing tools also work with Dendrite.
Given this is already getting huge (even though many test lines), splitting this into two PRs. (The next adds "getting one report" and "deleting reports")

@S7evinK S7evinK requested a review from a team as a code owner March 21, 2024 08:43
@S7evinK S7evinK force-pushed the s7evink/admin-event-reports branch from ff91be4 to 4bb91c6 Compare March 21, 2024 09:26
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 79.89418% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 67.39%. Comparing base (b9abbf7) to head (b62095b).

Files Patch % Lines
roomserver/storage/shared/storage.go 66.66% 14 Missing and 11 partials ⚠️
clientapi/routing/admin.go 75.00% 4 Missing and 1 partial ⚠️
...omserver/storage/postgres/reported_events_table.go 90.24% 2 Missing and 2 partials ⚠️
...oomserver/storage/sqlite3/reported_events_table.go 90.24% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3342      +/-   ##
==========================================
+ Coverage   67.35%   67.39%   +0.04%     
==========================================
  Files         521      521              
  Lines       47027    47216     +189     
==========================================
+ Hits        31674    31823     +149     
- Misses      11378    11404      +26     
- Partials     3975     3989      +14     
Flag Coverage Δ
unittests 52.69% <79.89%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK force-pushed the s7evink/admin-event-reports branch from 4bb91c6 to b62095b Compare March 21, 2024 18:36
@S7evinK S7evinK merged commit 79072c3 into main Mar 22, 2024
20 checks passed
@S7evinK S7evinK deleted the s7evink/admin-event-reports branch March 22, 2024 21:32
S7evinK added a commit that referenced this pull request Mar 22, 2024
Based on #3342

Adds `GET /_synapse/admin/v1/event_reports/{reportID}` and `DELETE
/_synapse/admin/v1/event_reports/{reportID}`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant