Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History visibility convenience functions #318

Merged
merged 3 commits into from
Jun 16, 2022
Merged

History visibility convenience functions #318

merged 3 commits into from
Jun 16, 2022

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Jun 14, 2022

Updates the default value to shared as per the spec:

By default if no history_visibility is set, or if the value is not understood, the visibility is assumed to be shared.

Adds some helper functions to convert between int and string (e.g. when storing numeric values in the database)

@S7evinK S7evinK marked this pull request as draft June 14, 2022 12:51
@S7evinK S7evinK mentioned this pull request Jun 15, 2022
Merged
@S7evinK S7evinK marked this pull request as ready for review June 15, 2022 05:12
@S7evinK S7evinK merged commit e98b9a0 into main Jun 16, 2022
@S7evinK S7evinK deleted the s7evink/hisvis branch June 16, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S7evinK @neilalexander