Add the ability to deactivate users to prevent them from ever being bridged #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop userId &&
|
The changelog file is empty. |
|
Good catch |
…ppservice-irc into hs/user-deactivation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few users have noted that they are re-bridged even after deactivating their account. The bridge will always reconnect users if they join an IRC bridged room. However, due to state resets (a bug where older v1-2 version rooms could revert their state to a previous point in time) these users may end up reappearing in the room. I can't seem to find an actual issue that describes the 'state reset bug', but there you go.
If the user reappears in the room, they may get reconnected even if they have since deleted their account. The IRC bridge should therefore keep track of users who have deactivated their accounts. In the future. MSC2438 will allow us to listen for these deactivation requests, but for now this offers us a manual way to do it.