Disable userid escaping entirely #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supercedes #750 and fixes #749, #744.
The long and short of it is that escaping userids is a bit of a fail because the IRC bridge handles userids differently across the bridge and it is not an easy job to go around picking them out and converting them. Certainly the appservice-bridge library should not attempt to blanket apply escaping like this.
For now, this PR disables escaping to fix the issues that have popped up until I have time to fix this properly. I really hope we fix this properly.
Depends upon matrix-org/matrix-appservice-bridge#112