Skip to content

Commit

Permalink
Set PTT mode on call correctly (#2445)
Browse files Browse the repository at this point in the history
And not always to true. This was causing audio & video to start muted
sometimes on normal calls because the ICE connection state would change
to 'checking', causing the feeds to be muted.
  • Loading branch information
dbkr authored Jun 8, 2022
1 parent 34ef7bc commit 5e76697
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/webrtc/groupCall.ts
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,7 @@ export class GroupCall extends TypedEventEmitter<GroupCallEvent, GroupCallEventH
logger.log(`GroupCall: incoming call from: ${opponentMemberId}`);

// we are handlng this call as a PTT call, so enable PTT semantics
newCall.isPtt = true;
newCall.isPtt = this.isPtt;

// Check if the user calling has an existing call and use this call instead.
if (existingCall) {
Expand Down Expand Up @@ -778,7 +778,7 @@ export class GroupCall extends TypedEventEmitter<GroupCallEvent, GroupCallEventH
},
);

newCall.isPtt = true;
newCall.isPtt = this.isPtt;

const requestScreenshareFeed = opponentDevice.feeds.some(
(feed) => feed.purpose === SDPStreamMetadataPurpose.Screenshare);
Expand Down

0 comments on commit 5e76697

Please sign in to comment.