Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support rewriting push rules when our internal defaults change #1006

Merged
merged 3 commits into from
Aug 1, 2019
Merged

Support rewriting push rules when our internal defaults change #1006

merged 3 commits into from
Aug 1, 2019

Conversation

turt2live
Copy link
Member

and change our internal default for tombstones

@turt2live
Support rewriting push rules when our internal defaults change
5c2aa46 
and change our internal default for tombstones
@turt2live turt2live requested a review from a team July 31, 2019 16:53
@bwindels bwindels requested review from bwindels and removed request for a team August 1, 2019 09:43
bwindels
bwindels reviewed Aug 1, 2019
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok, but have some questions. Also, is there a ticket somewhere for more context on the motivation behind these changes?

src/sync.js Show resolved Hide resolved
src/pushprocessor.js Show resolved Hide resolved
@turt2live turt2live merged commit a40d691 into develop Aug 1, 2019
@turt2live turt2live deleted the travis/tombstone-push branch August 1, 2019 14:22
@turt2live turt2live mentioned this pull request Aug 1, 2019
Merged
@turt2live turt2live mentioned this pull request Aug 12, 2019
Merged
@dbkr dbkr mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwindels bwindels bwindels approved these changes

Assignees
No one assigned
Labels
X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @bwindels