Clean up a codepath that was only used for crypto messages #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transmission of encrypted messages was happening somewhat differently to normal messages. In particular, we weren't copying the 'unsigned' field when we got the remote-echo, which meant the 'sync' code didn't correctly match up the echo with the original. The separate codepath was becoming a thorn in my side, so fix things up to bring it back in line.
Fix broken unit tests which expected echoes to get matched up when transaction_ids weren't set
We ought to set the transaction_id in this test too
|
Seems reasonable although I'm failing to understand how this has impacted the event.unsigned thing for normal messages if you're only changing stuff that ran for encrypted events? |
|
You mean, why did I have to change the tests? Because the tests were relying on the bit of code which I have removed. It was only used by encrypted events when live, but the test wasn't accurately reproducing what we get from the server, so was ending up in the wrong bit of code. |
|
Oh, I see - yes, that is very bizarre. lgtm then. |
richvdh
added a commit
that referenced
this pull request
Mar 15, 2016
Clean up a codepath that was only used for crypto messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transmission of encrypted messages was happening somewhat differently to
normal messages. In particular, we weren't copying the 'unsigned' field when we
got the remote-echo, which meant the 'sync' code didn't correctly match up the
echo with the original.
The separate codepath was becoming a thorn in my side, so fix things up to
bring it back in line.