Change ICE fallback server and make fallback opt-in #1015
Conversation
There's no longer a need to translate ICE server objects for Firefox, as it supports the `urls` array since version 37.
This changes the STUN fallback server from a Google server to one hosted at `turn.matrix.org`. Part of element-hq/element-web#10173
This changes the ICE server fallback to be disabled by default. The SDK consumer will receive a new event in case the homeserver has no ICE servers of its own, and can prompt the user to agree to the fallback if desired. Part of element-hq/element-web#10173
turt2live
changed the title
There was a problem hiding this comment.
I think this is fine. A bit unfortunate that it causes clients to prompt on startup though :(
(imo it should only show up when you make a call, to avoid throwing dialogs at all the people who haven't bothered to set up a TURN server because they don't make calls)
I also agree it is unfortunate, so you may wish to shout about this... I also don't make calls or intend to make them in future... The reasoning for showing on session start is so that we have prearranged permission for incoming calls. It's not exactly clear if that's a strong enough reason to justify annoying every user on session start. 😓 |
|
I've posted my rant at element-hq/element-web#10546 |
This adds a new client init option to configure whether an ICE fallback server is allowed to be used.
The intended flow has changed so we prompt about this case in context of making a call, so this event is no longer needed.
This changes the STUN fallback server from a Google server to one hosted at
turn.matrix.org. This also changes the ICE server fallback to be disabled by default. The SDK consumer will receive a new event in case the homeserver has no ICE servers of its own,and can prompt the user to agree to the fallback if desired.
Part of element-hq/element-web#10173
Used by matrix-org/matrix-react-sdk#3309