Add getIdServer() & doesServerRequireIdServerParam() #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove individual cache for lazy loading and just cache the whole versions response, then we can cache both of these flags
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Aug 16, 2019
If the server advertises that it supports doing so Requires matrix-org/matrix-js-sdk#1018 Requires matrix-org/matrix-js-sdk#1019 Fixes element-hq/element-web#10572
turt2live
approved these changes
Aug 16, 2019
| @@ -4059,15 +4060,38 @@ MatrixClient.prototype.doesServerSupportLazyLoading = async function() { | |||
| prefix: '', | |||
| }, | |||
| ); | |||
| } | |||
| return this._serverVersionsCache; | |||
There was a problem hiding this comment.
we should expire this after ~8 hours, similar to how capabilities are dealt with. Concern would be someone who runs Riot for days on end (me) and upgrades their server in the background.
manuroe
added a commit
to matrix-org/matrix-ios-sdk
that referenced
this pull request
Aug 29, 2019
…rverAcceptIdentityAccessToken properties. As implemented in matrix-org/matrix-js-sdk#1018 and matrix-org/matrix-js-sdk#1022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove individual cache for lazy loading and just cache the whole
versions response, then we can cache both of these flags