Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local trust for key backups #1075

Merged
merged 2 commits into from
Nov 18, 2019
Merged

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Nov 18, 2019

#832 added cross-signing checks for backup trust but we failed to merge in the check for the the backup being trusted locally.

Fixes element-hq/element-web#11404

#832 added
cross-signing checks for backup trust but we failed to merge in the
check for the the backup being trusted locally.

Fixes element-hq/element-web#11404
@dbkr dbkr requested a review from a team November 18, 2019 13:32
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a reasonable fix on the surface 👍

@dbkr dbkr merged commit 41680f6 into develop Nov 18, 2019
@t3chguy t3chguy deleted the dbkr/fix_key_backup_local_trust branch May 10, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key backup claims to be disabled despite being set up
2 participants