Refactor transmitted-messages code #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is some preparatory work for fixing up the problems with te timeline ordering of unsent messages (element-hq/element-web#1120). The functional changes here should be minimal (bar an extra `Room.localEchoUpdated` when the local echo is first added to the timeline). Give `MatrixClient.sendEvent` its own entry point `Room.addPendingMessage` instead of pushing it through `addEventsToTimeline`; this considerably simplifies the implementation of the latter and also means that we can contain the `_txnId` ming to MatrixClient. Move the code which deals with a successful `/send` response from `MatrixClient` into `Room.updatePendingEvent`, since it involves fiddling with the innards of the Room. Also adds a new EventStatus 'SENT' for events which have been successfully sent but whose remote echo we still haven't received.
|
lgtm |
richvdh
added a commit
that referenced
this pull request
Mar 17, 2016
Refactor transmitted-messages code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some preparatory work for fixing up the problems with the timeline ordering of unsent messages
(element-hq/element-web#1120). The functional changes here should be minimal (bar an extra
Room.localEchoUpdatedwhen the local echo is first added to the timeline).Give
MatrixClient.sendEventits own entry pointRoom.addPendingMessageinstead of pushing it throughaddEventsToTimeline; this considerably simplifies the implementation of the latter and also means that we can contain the_txnIdming to MatrixClient.Move the code which deals with a successful
/sendresponse fromMatrixClientintoRoom.updatePendingEvent, since it involves fiddling with the innards of the Room.Also adds a new EventStatus 'SENT' for events which have been successfully sent but whose remote echo we still haven't received.