-
-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for .ready verification event (MSC2366) & other things #1140
Commits on Jan 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 882d3a7 - Browse repository at this point
Copy the full SHA 882d3a7View commit details -
return request instead of verifier from verification methods
as MSC2366 adds an extra interactive step to the verification process, we can't wait for the verifier after sending the request. This is a breaking change in the js-sdk as it changes the return type of an existing method.
Configuration menu - View commit details
-
Copy full SHA for 2da7253 - Browse repository at this point
Copy the full SHA 2da7253View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10e2947 - Browse repository at this point
Copy the full SHA 10e2947View commit details -
expose common phases as properties
so we don't need to import the PHASE_ constants where we need to check
Configuration menu - View commit details
-
Copy full SHA for 28e46a8 - Browse repository at this point
Copy the full SHA 28e46a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c6dd56 - Browse repository at this point
Copy the full SHA 4c6dd56View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd7cc1b - Browse repository at this point
Copy the full SHA cd7cc1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b34a2c7 - Browse repository at this point
Copy the full SHA b34a2c7View commit details -
store in-room verification requests by roomId, txnId
as it's harder to determine the other side of a request, given the in-room code also processes remote echos for own events.
Configuration menu - View commit details
-
Copy full SHA for c4142d9 - Browse repository at this point
Copy the full SHA c4142d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f9e822 - Browse repository at this point
Copy the full SHA 5f9e822View commit details -
Configuration menu - View commit details
-
Copy full SHA for dac4a54 - Browse repository at this point
Copy the full SHA dac4a54View commit details -
don't block remote echos to VerificationRequests
also put logic to block non-participating senders in VerificationRequest so it is shared between both channels. Remote echo's should not be passed to the verifier though.
Configuration menu - View commit details
-
Copy full SHA for 984b623 - Browse repository at this point
Copy the full SHA 984b623View commit details -
only move to PHASE_DONE when both .done events are received
as once in done, the request is removed from the request map and the second .done event that comes in will not find the request anymore, so the request wouldn't be attached to the event anymore, breaking rendering it in the timeline.
Configuration menu - View commit details
-
Copy full SHA for 29c04b6 - Browse repository at this point
Copy the full SHA 29c04b6View commit details -
get other user id from channel
next up is inspecting the .request event to determine it reliably in InRoomChannel
Configuration menu - View commit details
-
Copy full SHA for efe2488 - Browse repository at this point
Copy the full SHA efe2488View commit details -
get other party user id by inspecting initial event sender/to fields
also fail validation with any event not sent by or directed to us
Configuration menu - View commit details
-
Copy full SHA for 48977e6 - Browse repository at this point
Copy the full SHA 48977e6View commit details -
move blocking non-participating users back to InRoomChannel
as it doesn't need to happen for ToDeviceChannel
Configuration menu - View commit details
-
Copy full SHA for 883b83f - Browse repository at this point
Copy the full SHA 883b83fView commit details -
attempt at only creating verifier for live events
but doesn't work yet? data where liveEvent is fished out is undefined
Configuration menu - View commit details
-
Copy full SHA for e7bcb61 - Browse repository at this point
Copy the full SHA e7bcb61View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf42ad8 - Browse repository at this point
Copy the full SHA cf42ad8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d3d27a - Browse repository at this point
Copy the full SHA 0d3d27aView commit details -
don't mark events loaded from cache as live events
this makes the verifier want to interact with the other party when just reloading the session.
Configuration menu - View commit details
-
Copy full SHA for 57135a8 - Browse repository at this point
Copy the full SHA 57135a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ed51c8 - Browse repository at this point
Copy the full SHA 8ed51c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ec8233 - Browse repository at this point
Copy the full SHA 3ec8233View commit details -
use isRemoteEcho to determine if the event is theirs or not
rather than the sender and from_device (which is not always set) as this was one of the things breaking to_device verification of ones own devices.
Configuration menu - View commit details
-
Copy full SHA for 423c8a8 - Browse repository at this point
Copy the full SHA 423c8a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a9dc37 - Browse repository at this point
Copy the full SHA 3a9dc37View commit details -
allow to move straight from UNSENT to STARTED
this was one of the things breaking to_device verification
Configuration menu - View commit details
-
Copy full SHA for 213bb9d - Browse repository at this point
Copy the full SHA 213bb9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5919874 - Browse repository at this point
Copy the full SHA 5919874View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75fc25f - Browse repository at this point
Copy the full SHA 75fc25fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9338d9c - Browse repository at this point
Copy the full SHA 9338d9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f44e0a8 - Browse repository at this point
Copy the full SHA f44e0a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72fd1e4 - Browse repository at this point
Copy the full SHA 72fd1e4View commit details
Commits on Jan 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1205178 - Browse repository at this point
Copy the full SHA 1205178View commit details
Commits on Jan 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 07cc93c - Browse repository at this point
Copy the full SHA 07cc93cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 59bfc45 - Browse repository at this point
Copy the full SHA 59bfc45View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbe2965 - Browse repository at this point
Copy the full SHA cbe2965View commit details
Commits on Jan 20, 2020
-
to make this work while using fake timers, don't use setTimeout
but instead use Promise.resolved() as then always runs in the next tick.
Configuration menu - View commit details
-
Copy full SHA for e51ba79 - Browse repository at this point
Copy the full SHA e51ba79View commit details -
Configuration menu - View commit details
-
Copy full SHA for c34ccc9 - Browse repository at this point
Copy the full SHA c34ccc9View commit details -
enable fake timers for consistency
although it doesn't make or break the test
Configuration menu - View commit details
-
Copy full SHA for e895283 - Browse repository at this point
Copy the full SHA e895283View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77d0a76 - Browse repository at this point
Copy the full SHA 77d0a76View commit details -
Configuration menu - View commit details
-
Copy full SHA for c12a3b6 - Browse repository at this point
Copy the full SHA c12a3b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 121e9d0 - Browse repository at this point
Copy the full SHA 121e9d0View commit details -
set transaction_id for remote echos in TestClient
as InRoomChannel looks at this to decide whether an event is a remote echo (and to pass it to the verifier or not)
Configuration menu - View commit details
-
Copy full SHA for e5c65d5 - Browse repository at this point
Copy the full SHA e5c65d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd9a2c1 - Browse repository at this point
Copy the full SHA bd9a2c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for aac6829 - Browse repository at this point
Copy the full SHA aac6829View commit details -
update jsdoc of requestVerificationDM
which now returns a Promise of VerificationRequest instead of verifier
Configuration menu - View commit details
-
Copy full SHA for d526229 - Browse repository at this point
Copy the full SHA d526229View commit details -
remove obsolete and now broken method
a request should be accepted by calling accept() on the request.
Configuration menu - View commit details
-
Copy full SHA for 9d6f873 - Browse repository at this point
Copy the full SHA 9d6f873View commit details