Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a prepare script #1161

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Add a prepare script #1161

merged 2 commits into from
Jan 22, 2020

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jan 22, 2020

So we actually build the lib directory before publishing it

@dbkr
Add a prepublish script
08465cf 
So we actually build the lib directory before publishing it
@dbkr dbkr requested a review from a team January 22, 2020 14:09
@dbkr dbkr changed the title Add a prepublish script Add a prepare script Jan 22, 2020
turt2live
turt2live reviewed Jan 22, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, change itself seems fine but I think it's best to block this behind figuring out the build system.

@dbkr
Copy link
Member Author

dbkr commented Jan 22, 2020

merging as per chat

@dbkr dbkr merged commit d5e9155 into develop Jan 22, 2020
@dbkr dbkr mentioned this pull request Jan 22, 2020
Merged
@t3chguy t3chguy deleted the dbkr/prepublish branch May 10, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbkr @turt2live