Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update QR code handling for new spec #1175

Merged
merged 18 commits into from
Jan 30, 2020
Merged

Update QR code handling for new spec #1175

merged 18 commits into from
Jan 30, 2020

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Jan 27, 2020 •
edited
Loading

@turt2live
Update QR code handling for new URL
83241ac 
This doesn't have any meaningful change on the process, just makes it more in line with what we do.
@turt2live turt2live requested review from a team and removed request for a team January 27, 2020 14:23
@turt2live
Copy link
Member Author

nevermind, I guess this breaks everything...

@turt2live turt2live changed the title Update QR code handling for new URL Update QR code handling for new spec Jan 28, 2020
@turt2live turt2live mentioned this pull request Jan 28, 2020
Merged
@turt2live turt2live requested a review from a team January 29, 2020 15:16
@dbkr dbkr requested review from dbkr and removed request for a team January 29, 2020 15:19
dbkr
dbkr reviewed Jan 29, 2020
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible although not sure I understand a great deal of the context

src/crypto/verification/QRCode.js Outdated Show resolved Hide resolved
@turt2live turt2live requested a review from dbkr January 29, 2020 18:07
@turt2live
Copy link
Member Author

@dbkr can you quickly take a look at 5fbaa9c to make sure I didn't introduce any werid vulnerabilities?

@turt2live turt2live merged commit 620118a into develop Jan 30, 2020
@turt2live turt2live deleted the travis/update-qr-code branch January 30, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @dbkr